{"id":427,"date":"2015-04-09T11:41:16","date_gmt":"2015-04-09T09:41:16","guid":{"rendered":"http:\/\/floris.briolas.nl\/floris\/?p=427"},"modified":"2015-06-02T10:33:00","modified_gmt":"2015-06-02T08:33:00","slug":"first-pull-request-created","status":"publish","type":"post","link":"https:\/\/floris.briolas.nl\/floris\/2015\/04\/first-pull-request-created\/","title":{"rendered":"First Pull-request created."},"content":{"rendered":"

Well, it had to happen some day.<\/h1>\n

I’ve found an issue in a project <\/a>we are using @ work. I’ve created a fix and I\u00a0want to share it!.<\/p>\n

So this project is hosted on github, and it is indeed simple to add fixes.<\/p>\n

Just follow these steps :<\/p>\n

    \n
  1. Fork the project<\/li>\n
  2. Create a feature \/ fix branch<\/li>\n
  3. Apply fix.<\/li>\n
  4. Push to github.<\/li>\n
  5. View this branch on github<\/li>\n
  6. Push the “Create Pull Request” button<\/li>\n<\/ol>\n

    It will then show you if it can be merged at all. Add some information and you are done!<\/p>\n

    better details<\/a><\/p>\n

    The fix.<\/h1>\n

    I’ve created a rather simple fix. We are using the “Fluent.Ribbon” for a modern look and feel. But some of our controls are still winforms. There is nothing wrong with winforms, but a mixture of wpf and winforms is not always ideal.<\/p>\n

    Anyway, we have a combobox in our ribbon and when a winforms control has focus and you try to open this combobox in your ribbon, it acts up. \u00a0repro :\u00a0

    \n\n
    \n
    \n
    \n
    \"Icon\"<\/div>\n
    \n

    Fluent.Ribbon WindowsFormsHost_Issue<\/a><\/h3>\n
    <\/i> 1 file(s) <\/i> 72.47 KB<\/div>\n <\/div>\n
    \n Download<\/a>\n <\/div>\n <\/div>\n <\/div>\n<\/div>\n\n<\/div><\/p>\n

    \"MainWindow_2015-04-09_11-25-11\"<\/a><\/p>\n

    We have found this message in the debug window:<\/p>\n

    System.Windows.Data Error: 8 : Cannot save value from target back to source. BindingExpression:Path=IsDropDownOpen; DataItem=’ComboBox’ (Name=’StyleCbx’); target element is ‘ToggleButton’ (Name=’ToggleButton’); target property is ‘IsChecked’ (type ‘Nullable`1′) NullReferenceException:’System.NullReferenceException: Object reference not set to an instance of an object.
    \nat Fluent.ComboBox.OnDropDownOpened(EventArgs e)
    \nat System.Windows.Controls.ComboBox.OnIsDropDownOpenChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
    \nat System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
    \nat System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
    \nat System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
    \nat System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
    \nat System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType, Boolean isInternal)
    \nat System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
    \nat MS.Internal.Data.PropertyPathWorker.SetValue(Object item, Object value)
    \nat MS.Internal.Data.ClrBindingWorker.UpdateValue(Object value)
    \nat System.Windows.Data.BindingExpression.UpdateSource(Object value)’<\/p>\n

    Turns out that the fix was rather simple. The combobox of fluent expected the\u00a0Keyboard.FocusedElement<\/a>, to always be non-null.<\/p>\n

    Well this is not the case when dealing with a mixed technology window. So the fix was created and a pull request has been offered.<\/p>\n

     <\/p>\n

     <\/p>\n","protected":false},"excerpt":{"rendered":"

    Well, it had to happen some day. I’ve found an issue in a project we are using @ work. I’ve created a fix and I\u00a0want to share it!. So this project is hosted on github, and it is indeed simple to add fixes. Just follow these steps : Fork the project Create a feature \/ […]<\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"jetpack_post_was_ever_published":false,"_jetpack_newsletter_access":"","_jetpack_newsletter_tier_id":0,"jetpack_publicize_message":"","jetpack_is_tweetstorm":false,"jetpack_publicize_feature_enabled":true,"jetpack_social_post_already_shared":false,"jetpack_social_options":{"image_generator_settings":{"template":"highway","enabled":false}}},"categories":[3,11],"tags":[20],"jetpack_publicize_connections":[],"jetpack_featured_media_url":"","jetpack_sharing_enabled":true,"jetpack_shortlink":"https:\/\/wp.me\/p61yPs-6T","_links":{"self":[{"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/posts\/427"}],"collection":[{"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/comments?post=427"}],"version-history":[{"count":1,"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/posts\/427\/revisions"}],"predecessor-version":[{"id":433,"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/posts\/427\/revisions\/433"}],"wp:attachment":[{"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/media?parent=427"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/categories?post=427"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/floris.briolas.nl\/floris\/wp-json\/wp\/v2\/tags?post=427"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}